Skip to content

fix(FR-2849): narrow Suspense boundary in Add Revision modal for resource group change#7368

Closed
ironAiken2 wants to merge 1 commit into
mainfrom
05-12-fix_fr-2849_narrow_suspense_boundary_in_add_revision_modal_for_resource_group_change
Closed

fix(FR-2849): narrow Suspense boundary in Add Revision modal for resource group change#7368
ironAiken2 wants to merge 1 commit into
mainfrom
05-12-fix_fr-2849_narrow_suspense_boundary_in_add_revision_modal_for_resource_group_change

Conversation

@ironAiken2
Copy link
Copy Markdown
Contributor

@ironAiken2 ironAiken2 commented May 12, 2026

resolves #NNN (FR-MMM)

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@claude
fix(FR-2849): narrow Suspense boundary in Add Revision modal for reso…
e278acd 
…urce group change

Wrap ResourceAllocationFormItems in its own Suspense boundary so that
changing the resource group only re-suspends the resource-allocation
section instead of triggering the modal-level fallback and unmounting
the entire form body.
Copilot AI review requested due to automatic review settings May 12, 2026 07:03
@github-actions github-actions Bot added the size:S 10~30 LoC label May 12, 2026
@ironAiken2 Graphite App
Copy link
Copy Markdown
Contributor Author

ironAiken2 commented May 12, 2026

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented May 12, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI reviewed May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Narrow the Suspense boundary behavior in the Deployment “Add Revision” modal so that changing resource-related form values only suspends (shows a loading skeleton for) the resource-allocation section, instead of triggering the modal-level fallback that unmounts the whole form body and can drop in-progress user input.

Changes:

  • Wrap ResourceAllocationFormItems in its own <Suspense fallback={<Skeleton active />}> boundary within the form body.
  • Update the surrounding rationale comment to reflect the intended UX (keep the rest of the form mounted during resource-allocation re-suspends).

Comment thread react/src/components/DeploymentAddRevisionModal.tsx
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

Coverage Report for react-coverage (./react)

Status Category Percentage Covered / Total
🔵 Lines 6.46% 1783 / 27588
🔵 Statements 5.31% 1978 / 37205
🔵 Functions 5.18% 296 / 5707
🔵 Branches 3.72% 1293 / 34751
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react/src/components/DeploymentAddRevisionModal.tsx 0% 0% 0% 0% 88-1195
Generated in workflow #557 for commit e278acd by the Vitest Coverage Report Action

@ironAiken2
Copy link
Copy Markdown
Contributor Author

ironAiken2 commented May 14, 2026

Closing this PR — the underlying work will be addressed by FR-2862, which refactors the Add Revision flow (merging Deployment Content components into Modal components and adding Preset Mode). See: https://lablup.atlassian.net/browse/FR-2862

@ironAiken2 ironAiken2 closed this May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@ironAiken2 ironAiken2

Labels

size:S 10~30 LoC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ironAiken2 @claude